Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Support for cardinality detection #412

Merged
merged 4 commits into from
Jan 21, 2023
Merged

[BREAKING] Support for cardinality detection #412

merged 4 commits into from
Jan 21, 2023

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jan 20, 2023

No description provided.

@k1LoW k1LoW self-assigned this Jan 20, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Code Metrics Report

main (90b4bb6) #412 (daf0638) +/-
Coverage 67.2% 65.0% -2.2%
Code to Test Ratio 1:0.5 1:0.5 -0.0
Test Execution Time 2m21s 3m4s +43s
Details
  |                     | main (90b4bb6) | #412 (daf0638) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          67.2% |          65.0% | -2.2% |
  |   Files             |             33 |             34 |    +1 |
  |   Lines             |           3241 |           3298 |   +57 |
- |   Covered           |           2177 |           2143 |   -34 |
- | Code to Test Ratio  |          1:0.5 |          1:0.5 |  -0.0 |
  |   Code              |           8410 |           8545 |  +135 |
+ |   Test              |           3819 |           3867 |   +48 |
- | Test Execution Time |          2m21s |           3m4s |  +43s |

Code coverage of files in pull request scope (48.4% → 50.3%)

Files Coverage +/-
config/config.go 71.5% +1.4%
schema/cardinality.go 80.0% +80.0%
schema/json.go 56.0% +0.8%
schema/schema.go 28.4% 0.0%
schema/yaml.go 0.0% 0.0%

Reported by octocov

@k1LoW k1LoW changed the title [BREAKING] Add Cardinality [BREAKING] Support for cardinality detection Jan 21, 2023
@k1LoW k1LoW marked this pull request as ready for review January 21, 2023 09:40
@k1LoW k1LoW added enhancement New feature or request minor labels Jan 21, 2023
@k1LoW k1LoW merged commit 6aacc24 into main Jan 21, 2023
@k1LoW k1LoW deleted the cardinality branch January 21, 2023 09:40
@github-actions github-actions bot mentioned this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant