Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#478: replace STRING_AGG to allow older MSSQL versions #502

Merged
merged 4 commits into from
Jul 26, 2023
Merged

#478: replace STRING_AGG to allow older MSSQL versions #502

merged 4 commits into from
Jul 26, 2023

Conversation

Lytchev
Copy link
Contributor

@Lytchev Lytchev commented Jul 21, 2023

#478: Replaced STRING_AGG (appeared in MSSQL 2017) with old-fashioned string aggregation

@Lytchev
Copy link
Contributor Author

Lytchev commented Jul 21, 2023

Missed issue #306 and unaccepted fix very similar to mine.
Manual comparing of MSSQL queries execution results showed no difference to me on my DB, but unfortunately I have no idea of how to run project's tests.

@k1LoW
Copy link
Owner

k1LoW commented Jul 24, 2023

Manual comparing of MSSQL queries execution results showed no difference to me on my DB, but unfortunately I have no idea of how to run project's tests.

I believe that merging is not a problem as long as there are no differences from the current document 👍

@k1LoW
Copy link
Owner

k1LoW commented Jul 26, 2023

@Lytchev Great!! Thank you!!

I can't say it supports MSSQL2017 as I can't try it, but I can take in this Pull Request 👍

@k1LoW k1LoW merged commit 3d9951a into k1LoW:main Jul 26, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants