Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the case where name in index_info is NULL. #579

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented May 2, 2024

Fix #578 ( @tcanabrava Thank you!! )
ref: https://www.sqlite.org/pragma.html#pragma_index_info

  1. The name of the column being indexed. This columns is NULL if the column is the rowid or an expression.

Fix #578
ref: https://www.sqlite.org/pragma.html#pragma_index_info

> 3. The name of the column being indexed. This columns is NULL if the column is the rowid or an expression.
@k1LoW k1LoW self-assigned this May 2, 2024
@k1LoW k1LoW added the bug Something isn't working label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Code Metrics Report

main (c883454) #579 (730da2f) +/-
Coverage 54.2% 52.5% -1.6%
Code to Test Ratio 1:0.4 1:0.4 -0.0
Details
  |                    | main (c883454) | #579 (730da2f) |  +/-  |
  |--------------------|----------------|----------------|-------|
- | Coverage           |          54.2% |          52.5% | -1.6% |
  |   Files            |             51 |             51 |     0 |
  |   Lines            |           4557 |           4558 |    +1 |
- |   Covered          |           2468 |           2394 |   -74 |
- | Code to Test Ratio |          1:0.4 |          1:0.4 |  -0.0 |
  |   Code             |           9825 |           9827 |    +2 |
  |   Test             |           4113 |           4113 |     0 |

Code coverage of files in pull request scope (89.5% → 89.5%)

Files Coverage +/-
drivers/sqlite/sqlite.go 89.5% +0.1%

Reported by octocov

@k1LoW k1LoW merged commit 5216ed9 into main May 2, 2024
4 checks passed
@k1LoW k1LoW deleted the fix-index-null branch May 2, 2024 23:39
@github-actions github-actions bot mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite fails with "converting NULL to string is unsupported"
1 participant