Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay_penalty to rnnt_loss; Add constrained rnnt; Fix monotonic_lower_bound to make it more efficient. #16

Merged
merged 8 commits into from
Oct 31, 2022

Conversation

pkufool
Copy link
Contributor

@pkufool pkufool commented Aug 11, 2022

Fix #14

assert py.is_contiguous()

# The following statements are for efficiency
px, py = px.is_contiguous(), py.is_contiguous()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant:

px, py = px.contiguous(), py.contiguous()

Copy link
Contributor Author

@pkufool pkufool Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Thanks! I think I had fixed it in the consecutive commit.

@pkufool pkufool changed the title Fix contiguous Update rnnt_loss Oct 30, 2022
@pkufool
Copy link
Contributor Author

pkufool commented Oct 30, 2022

Update changes from k2:

@danpovey danpovey merged commit 2c2dc4b into k2-fsa:master Oct 31, 2022
@pkufool pkufool changed the title Update rnnt_loss Add delay_penalty to rnnt_loss; Add constrained rnnt; Fix monotonic_lower_bound to make it more efficient. Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError: assert py.is_contiguous()
3 participants