Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo 'maxNumSenetences' in file 'swift-api-examples/SherpaOnnx.swift' #934

Closed
BrutalCoding opened this issue May 28, 2024 · 2 comments · Fixed by #939
Closed

Fix typo 'maxNumSenetences' in file 'swift-api-examples/SherpaOnnx.swift' #934

BrutalCoding opened this issue May 28, 2024 · 2 comments · Fixed by #939

Comments

@BrutalCoding
Copy link
Contributor

While reviewing the swift-api-examples/SherpaOnnx.swift file, I noticed a small typo in a parameter name.

On line 660, the parameter is spelled as maxNumSenetences.
Source:

sherpa-onnx/swift-api-examples/SherpaOnnx.swift

Line 660 in b4f1006

maxNumSenetences: Int = 2

I propose changing it to:

maxNumSentences: Int = 2
@csukuangfj
Copy link
Collaborator

Thanks! Could you please create a PR to fix it?

@BrutalCoding
Copy link
Contributor Author

Sure will do, I was on mobile while reviewing that file, hence no PR haha. I'll open a PR today.

@BrutalCoding BrutalCoding mentioned this issue May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Typo 'maxNumSenetences' in SherpaOnnx.swift BrutalCoding/sherpa-onnx
2 participants
@csukuangfj @BrutalCoding