ログイン失敗時の手動入力URLがundefinedになってしまうバグを修正 #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ログイン失敗時に表示される手動入力URL
worksClient.punchingURLForPc
について、hue-kintai-slask-command/src/Code.ts
Lines 553 to 562 in d9daf99
中で使っている
domain
プロパティがundefinedになっているようでした。hue-kintai-slask-command/src/WorksClient.ts
Lines 134 to 136 in d9daf99
WorksClientの初期化時、プロパティに同時にセットする場合は個別にアクセス修飾子を付ける必要がありそうです。
動作を確認するテストと修正を加えてみました。