Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when zip-output-folder is root directory. Needs more errorhandling #20

Closed
ChristophyBarth opened this issue May 28, 2019 · 5 comments
Labels
Milestone

Comments

@ChristophyBarth
Copy link

Expected behavior

I expected the app to save the LogCat to file as I had earlier selected the storage location.


Actual behavior

Immediately I clicked on the 'Save LogCat to file' option, the app crashed


How to reproduce

  • Download, install and launch the latest version of the app
  • Select storage location
  • Scroll down to the end
  • Click on the 'Save LogCat to file' option
  • Observe the crash.

Device: Gionee f100s
Android version: v6.0
App version: v2.0.19.190413


Recording of the bug


@k3b
Copy link
Owner

k3b commented May 29, 2019

hello @chrisbarth01 . thanks for the error report.

In the video i saw that you choose the external-storage-root-directory for output zip folder.

I assume that your device does not allow to write to root folder.

Can you try if it works if you change to some subfolder?

If this was not the reason: without an errorlog i have no clue what has happened.

i assume that there is a permissin problem.

To help me analyse the problem: can you open the togozip-settings and check " [X] Debug Mode".
After the crash there is hopefully the error protocol in the text clipboard.

can you past the text in a text editor and attach it to this ticket?

@ChristophyBarth
Copy link
Author

It's so unfortunate that I can't even open the settings which I think is in the three dots at the top of the screen because the app still crashes (I already reported that too). However, I don't think that it's permission issue because immediately I launch the app, it asked me to grant storage permission and I granted the app permission to my device's internal storage.

@k3b
Copy link
Owner

k3b commented May 29, 2019

i just updated myanswer: Can you try if it works if you change to some subfolder?

@k3b
Copy link
Owner

k3b commented May 29, 2019

i just checked. the app crashes if i try to write to root without error-log and without log in clipboard. i have to fix this.

i keep this issue open to remind me to improve error-handling for this use case.

thanks again for reporting.

@k3b k3b changed the title App crashes when I click on 'Save LogCat to file' option App crashes when zip folder is root directory. need more errorhandling May 29, 2019
@k3b k3b added the bug label May 29, 2019
@k3b k3b changed the title App crashes when zip folder is root directory. need more errorhandling App crashes when zip-output-folder is root directory. Needs more errorhandling May 29, 2019
@k3b
Copy link
Owner

k3b commented Jun 5, 2019

fixed. Will be available in v2.0.20.190606 which i have just released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants