Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace log with logrus #112

Merged
merged 4 commits into from
Oct 1, 2019

Conversation

nlamirault
Copy link

@nlamirault nlamirault commented Sep 25, 2019

See #17

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault nlamirault changed the title Update: replace log with logrus [WIP] Replace log with logrus Sep 25, 2019
@iwilltry42 iwilltry42 self-requested a review September 26, 2019 06:56
@iwilltry42 iwilltry42 added the enhancement New feature or request label Sep 26, 2019
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! Thanks a lot for starting work on this :)

I have some suggestions here:

  • You could import logrus like this: log "github.com/sirupsen/logrus" and keep on using log.XYZ instead of replacing every instance of log with logrus
  • Everywhere, where the logged message starts with a "level" like "ERROR:", "WARN:", "DEBUG:", or something the like, you could replace the log.Println with the appropriate levelled logger of logrus, e.g. log.Debugln or log.Errorf and so on.

Thanks again, I really like to see the logging improving 👍

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for your contribution :)

cli/image.go Outdated Show resolved Hide resolved
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@iwilltry42 iwilltry42 merged commit 802038a into k3d-io:master Oct 1, 2019
@iwilltry42
Copy link
Member

Thank you @nlamirault !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants