fix: logs error shadowing exec error #1172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rename an inner error to
logsError
to stop it shadowing the value of a higher scopederr
.Why
The assignment from
io.ReadAll
was overwriting the value of the original error and stopping the logs of the failed exec from being printed.Implications
fixes #1171
Now when
k3d image import
fails the logs from the failed command will be logged (this is intended behaviour):