Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] v3/startCluster: add --wait and --timeout #252

Merged
merged 4 commits into from
May 29, 2020
Merged

[Feature] v3/startCluster: add --wait and --timeout #252

merged 4 commits into from
May 29, 2020

Conversation

iwilltry42
Copy link
Member

@iwilltry42 iwilltry42 commented May 28, 2020 •
edited

  • functionality mostly copy-pasted from createCluster

Fixes #222

@iwilltry42
startCluster: add --wait and --timeout
332c3a8 
- functionality mostly copy-pasted from createCluster
@iwilltry42 iwilltry42 added the enhancement New feature or request label May 28, 2020
@iwilltry42 iwilltry42 self-assigned this May 28, 2020
@iwilltry42 iwilltry42 marked this pull request as ready for review May 28, 2020 12:32
@iwilltry42 iwilltry42 changed the title [Feature] v3: startCluster: add --wait and --timeout [Feature] v3/startCluster: add --wait and --timeout May 28, 2020
@iwilltry42
Copy link
Member Author

iwilltry42 commented May 28, 2020 •
edited

Current issue: waitForLogMessage considers container logs from before the restart and thus returns early
UPDATE: fixed in 99f5a68

@iwilltry42 iwilltry42 removed the request for review from ibuildthecloud May 28, 2020 13:27
@iwilltry42 iwilltry42 marked this pull request as draft May 28, 2020 13:27
@iwilltry42
getNodeLogs: accept time.Time parameter
99f5a68 
- fixes startCluster's --wait/--timeout functionality
--> now doesn't check all the logs (e.g. from previous run)
----> no more false positives when checking for a specifc log message
only in the current run
@iwilltry42 iwilltry42 marked this pull request as ready for review May 29, 2020 09:22
@iwilltry42 iwilltry42 added this to the v3.0 - FROM scratch milestone May 29, 2020
@iwilltry42 iwilltry42 merged commit 637c48e into master May 29, 2020
@iwilltry42 iwilltry42 deleted the feature/start-cluster-wait-for-master branch May 29, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iwilltry42 iwilltry42

Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0 - FROM scratch
Development

Successfully merging this pull request may close these issues.

[FEATURE] --wait flag for the start command
1 participant
@iwilltry42