Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Docs: favicons and header changes #264

Merged
merged 2 commits into from
Jun 4, 2020
Merged

[Enhancement] Docs: favicons and header changes #264

merged 2 commits into from
Jun 4, 2020

Conversation

lvuch
Copy link
Contributor

@lvuch lvuch commented Jun 3, 2020

No description provided.

@iwilltry42 iwilltry42 self-requested a review June 4, 2020 06:09
@iwilltry42 iwilltry42 added the enhancement New feature or request label Jun 4, 2020
@iwilltry42 iwilltry42 added this to the v3.0 - FROM scratch milestone Jun 4, 2020
@iwilltry42 iwilltry42 changed the title favicons and header changes [Enhancement] Docs: favicons and header changes Jun 4, 2020
@iwilltry42
Copy link
Member

Hi Lauren, glad to see you working on the site style :)
Thanks for that already :)

iwilltry42
iwilltry42 requested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, the file docs/static/img/favicons_black_blue/favicon.ico went missing and is causing 404 errors now 🤔

mkdocs.yml Outdated Show resolved Hide resolved
iwilltry42
iwilltry42 approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@iwilltry42 iwilltry42 merged commit 85197b5 into k3d-io:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.0 - FROM scratch
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lvuch @iwilltry42