Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Only pull image if the image is not found #27

Merged
merged 2 commits into from
May 4, 2019
Merged

[ENHANCEMENT] Only pull image if the image is not found #27

merged 2 commits into from
May 4, 2019

Conversation

ibuildthecloud
Copy link
Contributor

No description provided.

iwilltry42
iwilltry42 previously approved these changes May 3, 2019
View reviewed changes
cli/container.go Show resolved Hide resolved
cli/container.go Show resolved Hide resolved
@iwilltry42 iwilltry42 added the enhancement New feature or request label May 3, 2019
@iwilltry42 iwilltry42 changed the title Only pull image if the image is not found [ENHANCEMENT] Only pull image if the image is not found May 3, 2019
@iwilltry42
Copy link
Member

iwilltry42 commented May 3, 2019 •
edited
Loading

I merged this into my local branch, accepting all of your incoming changes.
When I start a new cluster, I receive the following error messages:

2019/05/03 09:00:11 ERROR: failed to create cluster
ERROR: couldn't create container k3d-test1-server
Error response from daemon: page not found

The error seems to come from here:

if err := docker.ContainerStart(ctx, resp.ID, types.ContainerStartOptions{}); err != nil {
		return "", err
	}

iwilltry42
iwilltry42 requested changes May 3, 2019
View reviewed changes
cli/container.go Show resolved Hide resolved
@iwilltry42 iwilltry42 mentioned this pull request May 3, 2019
Closed
@ibuildthecloud
Copy link
Contributor Author

Updated

@iwilltry42
Copy link
Member

LGTM, thank you 👍

@iwilltry42 iwilltry42 merged commit a0d9089 into k3d-io:master May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibuildthecloud @iwilltry42