Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix kubeconfig write on windows (#626, @dragonflylee) #626

Merged
merged 2 commits into from Jun 10, 2021
Merged

fix kubeconfig write on windows (#626, @dragonflylee) #626

merged 2 commits into from Jun 10, 2021

Conversation

dragonflylee
Copy link
Contributor

fix kubeconfig write on windows

when using docker-machine with boot2docker on Windows
k3d write kubeconfig failed log below

DEBU[0133] Output path 'C:\Users\<UserName>\.kube\config' doesn't exist, trying to create it...
ERRO[0133] Failed to create output file 'C:\Users\<UserName>\.kube\config'
WARN[0133] open C:\Users\<UserName>\.kube\config: The system cannot find the path specified.
INFO[0133] You can now use it like this:

instead of using path.Dir, filepath.Dir is right way to get directory

iwilltry42
iwilltry42 approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution! :)

@iwilltry42 iwilltry42 changed the title fix kubeconfig write on windows fix kubeconfig write on windows (#626, @dragonflylee) Jun 10, 2021
@iwilltry42 iwilltry42 merged commit f648e38 into k3d-io:main Jun 10, 2021
@iwilltry42 iwilltry42 added this to the v4.5.0 milestone Jun 10, 2021
rancherio-gh-m pushed a commit that referenced this pull request Jun 10, 2021
@dragonflylee
commit f648e38
5b70b5d 
Author: 蜻蜓特派员 <dragonflylee@outlook.com>
Date:   Thu Jun 10 22:59:07 2021 +0800

    fix kubeconfig write on windows (#626, @dragonflylee)
@Gobi-one Gobi-one mentioned this pull request Jun 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwilltry42 iwilltry42 iwilltry42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dragonflylee @iwilltry42