Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darwin-arm64 to supported install.sh archs #676

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

colelawrence
Copy link
Contributor

What

Fixes macOS on M1 execution of ./install.sh

Why

curl -s https://raw.githubusercontent.com/rancher/k3d/main/install.sh | bash
No prebuilt binary for darwin-arm64.
To build from source, go to https://github.com/rancher/k3d
Failed to install k3d
	For support, go to https://github.com/rancher/k3d.

Implications

Does not affect existing functionality of actual CLI

@colelawrence colelawrence changed the title Add darwin-arm64 to supported archs Add darwin-arm64 to supported install archs Jul 16, 2021
@colelawrence colelawrence changed the title Add darwin-arm64 to supported install archs Add darwin-arm64 to supported install.sh archs Jul 16, 2021
@colelawrence
Copy link
Contributor Author

colelawrence commented Jul 16, 2021

I tested this in a very rudimentary way by adding a sed like the following:

$ curl -s https://raw.githubusercontent.com/rancher/k3d/main/install.sh | sed 's/amd64/arm64/' | bash
Preparing to install k3d into /usr/local/bin
Password:
k3d installed into /usr/local/bin/k3d
Run 'k3d --help' to see what you can do with it.

Copy link
Member

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh seems like we missed that when adding that arch 👍

@iwilltry42
Copy link
Member

Hi @colelawrence , thanks for your contribution! Merging right away 👍

@iwilltry42 iwilltry42 merged commit 979b497 into k3d-io:main Jul 17, 2021
rancherio-gh-m pushed a commit that referenced this pull request Jul 17, 2021
Author: Cole Lawrence <cole@colelawrence.com>
Date:   Sat Jul 17 02:37:46 2021 -0400

    Add darwin-arm64 to supported archs (#676)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants