[FEATURE] Plugin System #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoAntoniazzi
force-pushed
the
feature/plugin-architecture
branch
from
f9d2a91
to
4790f8e
Compare
|
Hi @FedericoAntoniazzi , thanks for your work on this! Looking forward to getting this into k3d :) |
|
Thank you, I'm going to fix the logger soon |
FedericoAntoniazzi
force-pushed
the
feature/plugin-architecture
branch
from
4790f8e
to
18b09f8
Compare
FedericoAntoniazzi
force-pushed
the
feature/plugin-architecture
branch
from
244c05b
to
0b5ba83
Compare
Creates 'k3d plugin' command and 2 subcommands: - `k3d plugin install`: Install a plugin - `k3d plugin remove`: Remove an installed plugin Both subcommands have yet to be implemented.
- Use `k3d plugin install owner/repo@tag` to install the `tag` release of the owner/repo github repository. `tag` could be omitted and latest will be used - The download location is $HOME/.k3d/plugins. - The release must contain executable files in the format pluginname-os-arch because k3d will look for compatible executable and download it
Introduce a struct representing a plugin entity and improve semantics
Enable the possibility to use `k3d plugin install < plugins.txt` in which plugins.txt is a list of plugins like: owner1/repo1 owner1/repo2@v1.2.3 Thanks also to @pspgt
FedericoAntoniazzi
force-pushed
the
feature/plugin-architecture
branch
from
0b5ba83
to
6927a74
Compare
|
I decided to take a step back and analyze the problem all together first. This PR has been closed because a new one will be opened really soon, we can use the code implemented here as know-how for the new PR. In the meantime I created a discussion for collecting ideas about plugin management: #741 . Contributions are highly appreciated 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implement a plugin system into k3d.
Why
Resolve #304
Implications
Introduces new commands:
k3d plugin install PLUGINto install a plugink3d plugin listto list installed pluginsk3d plugin remove PLUGINto remove an installed pluginPlugins will be taken from GitHub Releases and need the files names have to be like pluginname-os-arch because k3d will look for a compatible (same OS and arch of the system which k3d is running on) executable file and download it.
Roadmap
Future improvements
I'm going to work on this PR in my free time. In the meantime I would like to have feedbacks about code and maybe new ideas.