[Fix] Fix docker client creation by tls verify from env #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dragonflylee , I don't exactly remember how we ended up with the old code, but your changes are way cleaner, thank you! 🙂 |
|
Tested with a simple script that checks both ways: context and DOCKER_* env vars: https://github.com/rancher/k3d/blob/main/tests/local_test_remote_docker.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up for #674
support with TLS (via env
DOCKER_TLS_VERIFY)support with TLS (via context)
as alreay called
why not use client inside dockerCli created by function Initialize
fixes #801