Expose --agent-arg like --server-arg
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
LGTM! Thank you for your contribution :)
Maybe @andyz-dev could have a look as well and then merge it, if everything's fine 👍
|
Absolutely! Thanks for working on this tool. Its been very useful to me. |
|
In cli/command.go line 108, would you please consider the following alternative? k3AgentArgs := []string{''} Besides the small nit. The PR looks clean and neat. Thanks for the contribution! |
|
@andyz-dev it should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
--agent-argflag and forward those to k3s like we do for--server-arg.There is an agent arg in the cluster spec, but it is not forwarded to the container config when starting the container. This change exposes the agent arg so that options passed to kubernetes components in the master container can also be passed to workers.
Fixes #86