Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing wrong types to vectors(colors=...) hides the plot with hard to see error #37

Closed
martinal opened this issue May 30, 2017 · 2 comments
Assignees

Comments

@martinal
Copy link

I tried passing colors=... in the K3D.vectors(...) call in vector_animation_k3d.ipynb.

It took a few tries before arriving at this format

colors = np.zeros(z.shape + (2,), dtype='uint32')

although I did understand it quickly after I spotted the error message.

It's somewhat unconventional to show errors with overlays in the corner of a notebook and require looking at the browser console. Would you consider displaying the error in the output field? Also I believe this kind of dimension mismatch could be caught in the factory functions on the python side instead of going all the way to javascript.

This also highlights the need for documentation.

@artur-trzesiok
Copy link
Collaborator

Whole validation will be refactored. @tgandor is resposible for this. This error should be caught on python level. Error on js level is not a option in world of ipywidgets - that error are only for development purpose

@martinal
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants