-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended cli not working on linux (with solution) #101
Comments
What terminal program are you using?
…On Sat, Jul 25, 2020 at 6:06 PM Johannes Arlt ***@***.***> wrote:
All extended cli command are not working on linux because of the different
lineend (\r vs. \n).
In function cli_extended_commands (line ~ 12884)
please change
if (incoming_serial_byte == 13) { // carriage return - get out
to
if (incoming_serial_byte == 13 || incoming_serial_byte == 10) { // carriage return - get out
that's it.
Can't make a pull request, but it is quite simple.
BTW. Many thanks for the software.
73 de DL7UXA
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#101>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZNU4EVAFVNR6JK6OFG3BTR5NJNTANCNFSM4PHU7Q4A>
.
|
The terminal in arduino ide. |
Have you tried to set your Arduino IDE terminal to "Carriage Return" using
the control at the bottom of the window?
…On Sat, Jul 25, 2020 at 9:15 PM Johannes Arlt ***@***.***> wrote:
The terminal in arduino ide.
I found a lot of similar code. Some check of 10 and 13, some not. I see
this because same problem programing memories from CLI.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZNU4A5FF2NPBP76NWVL4DR5N7RPANCNFSM4PHU7Q4A>
.
|
It think its strange cause windows end of line should be "\r\n" and the unix one "\n". https://stackoverflow.com/questions/1761051/difference-between-n-and-r |
k3ng
added a commit
that referenced
this issue
Jul 26, 2020
Extended CLI commands now work with linefeed line terminations in addition to carriage return; Issue 101 (#101), (Thanks, devcpu)
Fixed in version 2020.07.26.01 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All extended cli command are not working on linux because of the different lineend (\r vs. \n).
In function cli_extended_commands (line ~ 12884)
please change
to
that's it.
Can't make a pull request, but it is quite simple.
BTW. Many thanks for the software.
73 de DL7UXA
The text was updated successfully, but these errors were encountered: