Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended cli not working on linux (with solution) #101

Closed
devcpu opened this issue Jul 25, 2020 · 5 comments
Closed

extended cli not working on linux (with solution) #101

devcpu opened this issue Jul 25, 2020 · 5 comments

Comments

@devcpu
Copy link

devcpu commented Jul 25, 2020

All extended cli command are not working on linux because of the different lineend (\r vs. \n).
In function cli_extended_commands (line ~ 12884)

please change

if (incoming_serial_byte == 13) {   // carriage return - get out

to

if (incoming_serial_byte == 13 || incoming_serial_byte == 10) {   // carriage return - get out

that's it.

Can't make a pull request, but it is quite simple.

BTW. Many thanks for the software.
73 de DL7UXA

@k3ng
Copy link
Owner

k3ng commented Jul 25, 2020 via email

@devcpu
Copy link
Author

devcpu commented Jul 26, 2020

The terminal in arduino ide.
I found a lot of similar code. Some check of 10 and 13, some not. I see this because same problem programing memories from CLI.

@k3ng
Copy link
Owner

k3ng commented Jul 26, 2020 via email

@tuxun
Copy link

tuxun commented Jul 26, 2020

It think its strange cause windows end of line should be "\r\n" and the unix one "\n". https://stackoverflow.com/questions/1761051/difference-between-n-and-r
please correct me if I"m wrong

k3ng added a commit that referenced this issue Jul 26, 2020
      Extended CLI commands now work with linefeed line terminations in addition to carriage return; Issue 101 (#101), (Thanks, devcpu)
@k3ng
Copy link
Owner

k3ng commented Jul 26, 2020

Fixed in version 2020.07.26.01

Thanks!
73
Goody
K3NG

@k3ng k3ng closed this as completed Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants