You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello.
I am not a programmer, but after browsing the code I have a few questions because the compiler shows warnings.
Line 7428, declaration:
byte number_sent = 0;
and the comparison below:
if ((number_sent > -1) && (number_sent < 10))
but byte it's an typedef uint8 byte;, so it's always bigger than a -1.
This is the case in several places.
It is similar in line 12674:
byte memory_number = serial_get_number_input(2,0, (number_of_memories+1), port_to_use, RAISE_ERROR_MSG);
and the comparison below:
if (memory_number > -1) {...}
the compiler informs you that this condition is always met.
I compile STM32F103.
73, Krzysztof
The text was updated successfully, but these errors were encountered:
Hello.
I am not a programmer, but after browsing the code I have a few questions because the compiler shows warnings.
Line 7428, declaration:
byte number_sent = 0;
and the comparison below:
if ((number_sent > -1) && (number_sent < 10))
but byte it's an typedef uint8 byte;, so it's always bigger than a -1.
This is the case in several places.
It is similar in line 12674:
byte memory_number = serial_get_number_input(2,0, (number_of_memories+1), port_to_use, RAISE_ERROR_MSG);
and the comparison below:
if (memory_number > -1) {...}
the compiler informs you that this condition is always met.
I compile STM32F103.
73, Krzysztof
The text was updated successfully, but these errors were encountered: