Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software question #70

Closed
sp9rqa opened this issue Jun 7, 2019 · 1 comment
Closed

Software question #70

sp9rqa opened this issue Jun 7, 2019 · 1 comment

Comments

@sp9rqa
Copy link

sp9rqa commented Jun 7, 2019

Hello.
I am not a programmer, but after browsing the code I have a few questions because the compiler shows warnings.
Line 7428, declaration:
byte number_sent = 0;

and the comparison below:
if ((number_sent > -1) && (number_sent < 10))

but byte it's an typedef uint8 byte;, so it's always bigger than a -1.
This is the case in several places.

It is similar in line 12674:
byte memory_number = serial_get_number_input(2,0, (number_of_memories+1), port_to_use, RAISE_ERROR_MSG);

and the comparison below:
if (memory_number > -1) {...}

the compiler informs you that this condition is always met.
I compile STM32F103.

73, Krzysztof

@k3ng
Copy link
Owner

k3ng commented Oct 23, 2019

You are correct. This will be fixed in the next code update.

Thanks and 73!
Goody
K3NG

@k3ng k3ng closed this as completed Oct 23, 2019
k3ng added a commit that referenced this issue Oct 23, 2019
      #70  Thanks, SP9RQA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants