Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command buttons 1-3 are not working with ARDUINO_GENERIC_STM32F103C. #100

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Command buttons 1-3 are not working with ARDUINO_GENERIC_STM32F103C. #100

merged 1 commit into from
Jul 17, 2020

Conversation

7m4mon
Copy link
Contributor

@7m4mon 7m4mon commented Jul 14, 2020

I build a K3NG Keyer with ARDUINO_GENERIC_STM32F103C.
I noticed command buttons 1-3 are not working. (Only "Button - 0" is working).
This issue caused because the range of AnalogRead() was different.
So, I fixed the range of "max_value" in "buttonarray.h"

#if defined(ARDUINO_ARCH_ESP32)
#define max_value 4095
#else
#define max_value 1023
#endif

#if defined(ARDUINO_ARCH_ESP32) || defined(ARDUINO_GENERIC_STM32F103C)
#define max_value 4095
#else
#define max_value 1023
#endif

I noticed command buttons 1-3 are not working. (Only "Button - 0" is working).
This issue caused because the range of AnalogRead() was different.
So, I fixed the range of "max_value" in "buttonarray.h"
@7m4mon 7m4mon changed the title I build a K3NG Keyer with ARDUINO_GENERIC_STM32F103C. Command buttons 1-3 are not working with ARDUINO_GENERIC_STM32F103C. Jul 14, 2020
@k3ng k3ng merged commit 82f5c1f into k3ng:master Jul 17, 2020
k3ng added a commit that referenced this pull request Jul 17, 2020
      Merge of pull request 100 - Command buttons 1-3 are not working with ARDUINO_GENERIC_STM32F103C (#100) (Thanks, 7m4mon)
@k3ng
Copy link
Owner

k3ng commented Jul 17, 2020

Thanks !

73
Goody
K3NG

@7m4mon
Copy link
Contributor Author

7m4mon commented Jul 18, 2020

It works very well !
TU, 73!

K3NG_Keyer1
K3NG_Keyer2

@7m4mon 7m4mon deleted the command_buttons_1-3_with_STM32F103C branch July 18, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants