Support for configuring the side tone line states. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstroie
changed the title
cstroie
changed the title
|
Thank you for the contribution! 73 |
k3ng
added a commit
that referenced
this pull request
Jul 2, 2020
Pull request 98 - Support for configuring the side tone line states - merged. (#98) (Thanks, Costin Stroie) New settings: sidetone_line_active_state, sidetone_line_inactive_state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be cases where the side tone digital line (no square wave generation, just a active beeper/buzzer attached) is active on LOW, not HIGH. For example the Arduino Multi Function Shield, a very convenient test platform. Therefore I added two defines in the spirit of the other active/inactive switches to control the HIGH/LOW states.
Then, I used these defines to replace all corresponding occurrences for HIGH and LOW such as: