update message to work around HTTP method validation #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the sent message to start with a letter other than ones of valid HTTP methods to bypass gateway validation. In a real scenario, the request would time-out.
|
@jitsni This is the PR for the HTTP method validation issue. Could you please take a look? |
|
@jitsni Can you take an action on this PR ? |
jitsni
reviewed
Jan 9, 2017
| @@ -38,21 +38,12 @@ read header "Date" /.+/ | |||
|
|
|||
| write [0x82 0x85] ${writeMask} | |||
| write option mask ${writeMask} | |||
| write "Hello" | |||
| write "World" | |||
There was a problem hiding this comment.
I see what happens in HTTP decoding when Hello is sent as method. Can you not just send "Hello World"
|
@danibusu Does this still need to get merged. If so, please answer Jitu's review comment. |
|
not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the sent message to start with a letter other than ones of valid
HTTP methods to bypass gateway validation. In a real scenario, the
request would time-out.