New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensible grammar and runtime #420
Conversation
Conflicts: specification/k3po.control/src/main/scripts/org/kaazing/specification/control/accept.already.prepared.or.started.rpt specification/k3po.control/src/main/scripts/org/kaazing/specification/control/accept.finished.with.barriers.rpt specification/k3po.control/src/main/scripts/org/kaazing/specification/control/connect.already.prepared.or.started.rpt specification/k3po.control/src/main/scripts/org/kaazing/specification/control/connect.finished.with.barriers.rpt
@@ -15,7 +15,7 @@ | |||
# | |||
|
|||
# | |||
# read and write track file position independently | |||
#read andwrite track file position independently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format clean up shouldn't change this
@@ -26,7 +26,7 @@ write http:header "Trailer" "Trailing-Header" | |||
write "Chunk A" | |||
write "Chunk B" | |||
# Not supported in netty 3.9 | |||
# write option chunkExtension "some-extension-value" | |||
#write option chunkExtension "some-extension-value" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format clean up should not change this comment
It whould be nice to now write:
as
Which I don't think is possible as Robot.g is now:
|
StructuredTypeInfo needs to
as it is called in several Ast*Nodes |
Should BehaviorSystem and others (WriteOptionFactory, ReadOptionFactory) be in public API (i.e. not internal packaging). Maybe file a follow-up ticket? |
@@ -15,7 +15,7 @@ | |||
# | |||
|
|||
# | |||
# read and write track file position independently | |||
#read andwrite track file position independently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sed script should not alter any comment lines
@jfallows Since connect and accept uri is now quoted will it allow syntax like
that we agreed we'll need for http spec tests? |
This reverts commit 2a8e2fb. Update tools/upgrade.sed to skip tidying comment lines
The The grammar updates for consecutive |
Investigating build breakage on Travis. |
Travis build working again. |
Note: we might need some further (minor) changes on stream validation to support custom extensions after |
Note: no need to hold for any changes on stream validation. |
Note: this requires a backwards incompatible change in the K3PO grammar.
Note: upgrade script provided in
tools/upgrade.sed
Added an extensible
TypeSystem
used by the parser to support custom language elements not present in the core, such ashttp:method
,http:version
http:header
, andhttp:status
.Added an extensible
BehaviorSystem
used by driver to support runtime enforcement of custom language elements.New transport schemes can now be implemented outside the K3PO project and be discovered via
ServiceLoader
by placing the artifact on the<dependency>
classpath of thek3po-maven-plugin
.