feat: support for trusting private CA #139
Conversation
|
hmm, I am never sure if I like this approach or building a minimal custom image with the CA included. |
There was a problem hiding this comment.
overall, looks good to me.
Since Node, unlike Java, can directly read extra CAs directly without the need of updating a trust-store, I see nothing wrong with doing this.
reasoning for the comment
I have wasted too many hours at work with our self signed CA and the ppl behind it that I am very cautious when it comes to this "feature"
that and quite a few other "official" charts with Java backed services use init container ... which is a wast of time and resources when you scale up and down frequently.
Thereby I generally advocate for building a custom image with the proper trust in cases where you need to change/patch anything to the likes of a trust-store, that not being the case here, I approve of this method.
Thank you for your contribution and sorry for the odd review comment.
|
Thank you for taking the time to look into this pull request, I really appreciate it |
Resolves #138