Mark DataSecretAvailable condition to true when setting dataSecretName

[mkmik]

Closes #15

I manually tried to edit the status subresource with the kubectl edit-status plugin and I confirm that once the DataSecretAvailable flips, then the Ready condition flips too and the cluster is fully initialized:

$ clusterctl describe cluster k3-test-2
NAME                                                          READY  SEVERITY  REASON  SINCE  MESSAGE
Cluster/k3-test-2                                             True                     143m
├─ClusterInfrastructure - AWSCluster/k3-test-2                True                     5h45m
├─ControlPlane - KThreesControlPlane/k3-test-2-control-plane  True                     143m
│ └─Machine/k3-test-2-control-plane-4s42f                     True                     5h45m
└─Workers
  └─MachineDeployment/k3-test-2-md-0                          True                     141m
    └─Machine/k3-test-2-md-0-6454966fcd-mvbnt                 True                     143m

(I still need to actually test the code by building my branch into an image and trying it out)

[mkmik]

I'm trying the build of my branch in ghcr.io/mkmik/cluster-api-k3s/bootstrap-controller:v0.1.5

(I don't have a local env; so I'm trying this out in my test account on AWS)

[mkmik]

nope it didn't work :-(

status:
  conditions:
  - lastTransitionTime: "2022-12-09T17:42:29Z"
    reason: WaitingForControlPlaneAvailable
    severity: Info
    status: "False"
    type: Ready
  - lastTransitionTime: "2022-12-09T17:42:29Z"
    status: "True"
    type: CertificatesAvailable
  - lastTransitionTime: "2022-12-09T17:42:29Z"
    reason: WaitingForControlPlaneAvailable
    severity: Info
    status: "False"
    type: DataSecretAvailable
  dataSecretName: k3-test-4-control-plane-q5vd4
  observedGeneration: 2
  ready: true

Ok, I think I'll have to actually read and understand the code a bit better and run the controller locally so I can iterate on it :-(

[zawachte]

nope it didn't work :-(

status:
  conditions:
  - lastTransitionTime: "2022-12-09T17:42:29Z"
    reason: WaitingForControlPlaneAvailable
    severity: Info
    status: "False"
    type: Ready
  - lastTransitionTime: "2022-12-09T17:42:29Z"
    status: "True"
    type: CertificatesAvailable
  - lastTransitionTime: "2022-12-09T17:42:29Z"
    reason: WaitingForControlPlaneAvailable
    severity: Info
    status: "False"
    type: DataSecretAvailable
  dataSecretName: k3-test-4-control-plane-q5vd4
  observedGeneration: 2
  ready: true

Ok, I think I'll have to actually read and understand the code a bit better and run the controller locally so I can iterate on it :-(

Sounds good!

A bit busy the next few days ... when I have a second, I would love to help out!

[mkmik]

I ran it locally with make run-bootstrap and it worked just fine. I think it may have pushed a bad image (i.e. not the code I actually build)

[mkmik]

no actually, it didn't work fine when I re-created the resource; it only worked when I restarted the controller after manually removing dataSecretName and ready. This means that I have to understand the state transitions and fix the bug properly.

Unfortunately it's EOD for me in this part of the world; I'll continue on Monday.

[mkmik]

ok, turns out there were two // conditions.MarkTrue(scope.Config, bootstrapv1.DataSecretAvailableCondition) lines to uncomment.

Now I got the controlplane working. The bootstrap data secret for the worker node still doesn't work, but I think that may be another problem.

[mkmik]

The issue I'm having with the workernode data secret is caused by https://github.com/zawachte/cluster-api-k3s/issues/17.

I confirm that with this PR I can get a cluster created correctly.

[zawachte]

@mkmik good to merge?

[mkmik]

yes