Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tilt provider support #30

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

cannonpalms
Copy link
Contributor

Closes #26

@richardcase
Copy link
Collaborator

@cannonpalms - there is already an open WIP for this (#27 ) and the issue is assigned to someone else. Curious why another PR was created that duplicates the effort?

Copy link
Collaborator

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cannonpalms
Copy link
Contributor Author

I didn't see the draft PR until after I'd completed this work, because it hadn't yet been linked to the issue #26. Sorry about that! I'd be happy to see either be merged.

@richardcase
Copy link
Collaborator

My bad, I didn't add fixes, doh.

I closed the other PR....let's go with this :)

@richardcase richardcase merged commit da514da into k3s-io:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable tilt integration
3 participants