Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use singular in --node-label and --node-taint flags #38

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: Use singular in --node-label and --node-taint flags #38

merged 1 commit into from
May 2, 2023

Conversation

mkmik
Copy link
Contributor

@mkmik mkmik commented Apr 27, 2023

Fixes #37

I left the Go fields to use plural and only changed the json field name to use the singular for uniformity with other []string fields in the same struct:

	KubeletArgs     []string `json:"kubelet-arg,omitempty"`
	KubeProxyArgs   []string `json:"kube-proxy-arg,omitempty"`

@zawachte zawachte merged commit 204444b into k3s-io:main May 2, 2023
@mkmik mkmik deleted the fix-labels branch October 2, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zawachte zawachte zawachte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node labels and node taints
2 participants
@mkmik @zawachte