Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.17] Bump to go 1.15 when upstream does #2235

Closed
cjellick opened this issue Sep 11, 2020 · 5 comments
Closed

[1.17] Bump to go 1.15 when upstream does #2235

cjellick opened this issue Sep 11, 2020 · 5 comments
Assignees
Milestone

Comments

@cjellick
Copy link
Contributor

For 1.17 and 1.18 we will need to update the go version we use to build when upstream does. Can track this issue:
kubernetes/release#1517

From: kubernetes/kubernetes#94037

Usually we don't backport Golang minor updates to previous branches, but because Kubernetes 1.19 will be built on go1.15 and go1.14 is being skipped by the Kubernetes community, we need to update to go1.15 on previous branches as well to remain on a supported Golang version for the Kubernetes 1.18 and 1.17 support cycles.

I've put this in the 1.17.12 milestone, but we just need to keep an eye on when and if they get it done upstream for that release. If it doesn't then we shouldn't move either

@cjellick cjellick added this to the v1.17.12+k3s1 milestone Sep 11, 2020
@cjellick
Copy link
Contributor Author

just for cross-reference:
#2230
#2234

@davidnuzik
Copy link
Contributor

Unless I'm mistaken it looks like this wasn't finished upstream. I've bumped this to the next patch release slated for November.

@davidnuzik
Copy link
Contributor

Now being tracked via kubernetes/release#1651
Looks like this is in progress now upstream based on a thread today in #sig-release in kubernetes slack.

@davidnuzik
Copy link
Contributor

We should bump to 1.15.5 or newer.

@davidnuzik
Copy link
Contributor

Closing. Not needed in 1.17 branch. Since upstream is not bumping the go version, we shall not as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants