Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][1.18][go1.15] Update to go1.15 #94037

Closed
wants to merge 2 commits into from
Closed

[WIP][1.18][go1.15] Update to go1.15 #94037

wants to merge 2 commits into from

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup
/area dependency release-eng
/sig release

What this PR does / why we need it:

Update to go1.15.0

Signed-off-by: Stephen Augustus saugustus@vmware.com

Tracking issue: kubernetes/release#1421

Special notes for your reviewer:

Usually we don't backport Golang minor updates to previous branches, but because Kubernetes 1.19 will be built on go1.15 and go1.14 is being skipped by the Kubernetes community, we need to update to go1.15 on previous branches as well to remain on a supported Golang version for the Kubernetes 1.18 and 1.17 support cycles.

This is a WIP PR. There are a few other commits to cherry pick before this is ready to go.
/hold

Does this PR introduce a user-facing change?:

- Kubernetes is now built with go1.15.0

@justaugustus
build/dependencies.yaml: Alpha-sort and group dependencies
47d99d1 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
[go1.15] Update to go1.15
b4524db 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Aug 16, 2020
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 16, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justaugustus
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 16, 2020
@justaugustus justaugustus mentioned this pull request Aug 16, 2020
Closed
33 tasks
@liggitt
Copy link
Member

liggitt commented Aug 16, 2020

it would be good to enumerate all the updates/picks required for this…

the most concerning ones I recall are the bbolt/etcd bump (required for go1.14+), and the x509 common name deprecation in go1.15 which has the potential to be a breaking change, which we are allergic to in patch releases for anything but severe security or bug fixes (e.g. data loss issues)

@justaugustus
Copy link
Member Author

justaugustus commented Aug 16, 2020 •
edited

it would be good to enumerate all the updates/picks required for this…

Heh, I was going to in kubernetes/release#1421 before tagging you here! :)
bbolt, etcd updates, errors.As for net, another error handling commit, and the cert stuff are what come to mind at the moment.

EDIT: Ahh yes, and the go directive changes + golang.org/x/... bumps

@warmchang warmchang mentioned this pull request Aug 27, 2020
Closed
This was referenced Aug 31, 2020
Open
Closed
@justaugustus justaugustus mentioned this pull request Sep 2, 2020
Closed
24 tasks
@dims
Copy link
Member

dims commented Sep 3, 2020

Do we still need this @justaugustus ?

@justaugustus
Copy link
Member Author

Do we still need this @justaugustus ?

This is still active, but dependent on #94449.

@cjellick cjellick mentioned this pull request Sep 11, 2020
Closed
@cjellick cjellick mentioned this pull request Sep 11, 2020
Closed
@warmchang
Copy link
Contributor

Do we still need this @justaugustus ?

This is still active, but dependent on #94449.

#94449 is done.
/retest

@k8s-ci-robot
Copy link
Contributor

@justaugustus: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test b4524db link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-kind b4524db link /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-gce b4524db link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cjellick
Copy link
Contributor

cjellick commented Oct 6, 2020

Think this is still going to happen for 1.18 and 1.17?

@justaugustus justaugustus mentioned this pull request Oct 21, 2020
Closed
35 tasks
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@warmchang
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@kubelsp
Copy link

kubelsp commented Feb 14, 2021

请问源码编译（容器方式）先拉取了镜像。怎样修改文件避免编译再次拉取。编译版本v1.18.15

@justaugustus
Copy link
Member Author

We're going to skip the upgrade at this point.
ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1612486916175400?thread_ts=1612480925.169900&cid=C2C40FMNF

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

We're going to skip the upgrade at this point.
ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1612486916175400?thread_ts=1612480925.169900&cid=C2C40FMNF

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@fejta fejta Awaiting requested review from fejta

Assignees
No one assigned
Labels
area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@justaugustus @k8s-ci-robot @liggitt @dims @warmchang @cjellick @fejta-bot @kubelsp