Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s fish completion #6612

Closed
RafalSkolasinski opened this issue Dec 3, 2022 · 4 comments
Closed

k3s fish completion #6612

RafalSkolasinski opened this issue Dec 3, 2022 · 4 comments

Comments

@RafalSkolasinski
Copy link

RafalSkolasinski commented Dec 3, 2022

Is your feature request related to a problem? Please describe.

I am using fish shell and would like to have shell completion for k3s.

Describe the solution you'd like

The

k3s completion fish

produces valid fish completions.

Describe alternatives you've considered

None.

Additional context

K3s only provides completion for bash and zsh. It'd be great if we could extend that to include also fish completions

$ k3s completion --help
NAME:
   k3s completion - Install shell completion script

USAGE:
   k3s completion [SHELL] (valid shells: bash, zsh)

OPTIONS:
   -i  Install source line to rc file

Also it seems that the issue is solved for k3d: https://k3d.io/v5.3.0/usage/commands/k3d_completion/

@dereknola
Copy link
Contributor

K3s uses urfave cli as the CLI library. This library has builtin support to generate bash and zsh completion code. It unfortunately does not support fish, which makes it unlikely that we will be able to add fish autocompletion to K3s. K3d uses cobra as its CLI library, which does have native fish support.

@RafalSkolasinski
Copy link
Author

:(

@caroline-suse-rancher
Copy link
Contributor

Closing as we don't have any current plans to change our CLI library.

@davidmathers
Copy link

Note:

Supported shells are bash, fish, zsh, powershell

urfave/cli#1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants