-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have k3s-upgrade bail out when user tries to downgrade a cluster #7537
Comments
We should probably also refuse to "upgrade" when:
|
@osodracnai if you're up for it I think this would be a good way to get some visibility into SUC/upgrades, want to pair with @brandond on it? cc @dereknola |
Just updating for visibility - dev is aware of this current state I am able to downgrade the cluster from 1.27.4-rc3+k3s1 to v1.26.7-rc3+k3s1 No error message is displayed and the upgrade finished without any issue
After applying the plan:
Steps to validate:
|
it can be tested after the release |
Upgrading from 1.27.4 to 1.26.7
|
I believe this is working as intended. If you configure the Plan to cordon the nodes, they won't uncordon until the plan is completed successfully. Since the downgrade is rejected, the plan will never succeed, and the nodes will remain cordoned. The alternative would be for the version checks to silently fail, and indicate that the upgrade was successful - essentially making the downgrade a no-op, instead of failure. To me this is less good, as the administrator may not notice the fact that the plan didn't succeed until they think to check the versions, and note that it did not in fact switch to the version they asked for. |
Closing as we have decided this is working per the design and have opened docs issue to address common pitfalls. |
Currently, when a user tries to write a SUC plan to downgrade their k8s cluster, k3s-upgrade will go ahead and try to follow the plan and then fail. Rather than allowing downgrades (which we don't want to do), we should simply bail out from an attempted downgrade and alert the user that a downgrade is not supported.
ref: SURE-5230
The text was updated successfully, but these errors were encountered: