Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cadvisor returns empty image #9672

Closed
dashie opened this issue Mar 7, 2024 · 10 comments
Closed

cadvisor returns empty image #9672

dashie opened this issue Mar 7, 2024 · 10 comments
Labels
docker Pull requests that update Docker code status/stale

Comments

@dashie
Copy link

dashie commented Mar 7, 2024

Environmental Info:
K3s Version: v1.29.2+k3s1 (86f1021)
OS: Ubuntu 22.04.4 LTS

Describe the bug:

Installed k3s on ubuntu with docker. When I call:

kubectl get --raw /api/v1/nodes/<node>/proxy/metrics/cadvisor

the metrics returned have all image empty (image="")

@brandond
Copy link
Contributor

brandond commented Mar 7, 2024

Have you tested to see if this works with a standalone deployment of cri-dockerd? The version of cri-dockerd embedded in k3s is fairly up to date, its possible this is an upstream issue.

What version of docker are you using?

@dashie
Copy link
Author

dashie commented Mar 7, 2024

Have you tested to see if this works with a standalone deployment of cri-dockerd? The version of cri-dockerd embedded in k3s is fairly up to date, its possible this is an upstream issue.

What version of docker are you using?

You are suggesting me to not to use docker?

And to install k3s in this way?

curl -sfL https://get.k3s.io | INSTALL_K3S_CHANNEL=latest sh -s -

If so, I confirm you. If I don'r use docker-ce, it works!
But how can I make it works with docker-ce?

@brandond
Copy link
Contributor

brandond commented Mar 7, 2024

You are suggesting me to not to use docker?

No, I was asking what happens if you install cri-dockerd on your own, and use that as the --container-runtime-endpoint instead of using the cri-dockerd built into k3s.

Is there some particular reason you're required to use docker, though?

@dashie
Copy link
Author

dashie commented Mar 7, 2024

Is there some particular reason you're required to use docker, though?

The reason is that docker-ce was already installed and used (by other) on that server. And I just wanted to add k3s.
Anyway I can confirm, if I remove docker-ce and I use the embedded k3s docker, everything works on cadvisor side.
With docker-ce some label are missing.

@jiayu997
Copy link

@dashie k3s has embedded docker ? i also meet this problem

@brandond
Copy link
Contributor

He means containerd.

@jiayu997
Copy link

@brandond = =、thanks

@dashie
Copy link
Author

dashie commented Mar 14, 2024

@dashie k3s has embedded docker ? i also meet this problem

See here https://docs.k3s.io/advanced#using-docker-as-the-container-runtime.

I was having the problem using "docker" (activated with the option --docker). Using "containerd" I have no problem. But I would still like to understand why.

@jiayu997
Copy link

@dashie k3s has embedded docker ? i also meet this problem

See here https://docs.k3s.io/advanced#using-docker-as-the-container-runtime.

I was having the problem using "docker" (activated with the option --docker). Using "containerd" I have no problem. But I would still like to understand why.

i should try k8s < 1.24, maybe it works

Copy link
Contributor

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 45 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code status/stale
Projects
Status: Done Issue
Development

No branches or pull requests

3 participants