Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes V1.30.0-k3s1 #10063

Merged
merged 10 commits into from
May 6, 2024
Merged

Conversation

galal-hussein
Copy link
Contributor

Proposed Changes

Updates for v1.30.0-k3s1, these updates changes the following:

  • Update dynamiclistener to v0.5.0-rc5
  • Update kine to v0.11.8
  • Update cri-dockerd to v0.3.12-k3s1.30
  • Update klog to v2.120.1-k3s1
  • Update wrangler to v3

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
dereknola
dereknola previously approved these changes May 2, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 41.80%. Comparing base (d973fad) to head (6ad14fc).
Report is 6 commits behind head on master.

Files Patch % Lines
...d/controllers/k3s.cattle.io/v1/etcdsnapshotfile.go 0.00% 20 Missing ⚠️
pkg/cli/cmds/log_linux.go 0.00% 1 Missing ⚠️
pkg/cli/token/token.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10063      +/-   ##
==========================================
- Coverage   49.90%   41.80%   -8.10%     
==========================================
  Files         158      173      +15     
  Lines       14017    14647     +630     
==========================================
- Hits         6995     6123     -872     
- Misses       5696     7362    +1666     
+ Partials     1326     1162     -164     
Flag Coverage Δ
e2etests 36.40% <17.24%> (-10.03%) ⬇️
inttests 37.09% <20.68%> (-0.08%) ⬇️
unittests 11.38% <0.00%> (-5.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

briandowns
briandowns previously approved these changes May 3, 2024
matttrach
matttrach previously approved these changes May 3, 2024
pkg/proctitle/proctile.go Outdated Show resolved Hide resolved
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
@galal-hussein galal-hussein dismissed stale reviews from matttrach and briandowns via bf6e874 May 3, 2024 16:30
dereknola
dereknola previously approved these changes May 3, 2024
vitorsavian
vitorsavian previously approved these changes May 3, 2024
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
github.com/cloudnativelabs/kube-router/v2 => github.com/k3s-io/kube-router/v2 v2.1.0
github.com/containerd/containerd => github.com/k3s-io/containerd v1.7.15-k3s1
github.com/docker/distribution => github.com/docker/distribution v2.8.3+incompatible
github.com/docker/docker => github.com/docker/docker v25.0.4+incompatible
github.com/emicklei/go-restful/v3 => github.com/emicklei/go-restful/v3 v3.9.0
github.com/golang/protobuf => github.com/golang/protobuf v1.5.4
github.com/googleapis/gax-go/v2 => github.com/googleapis/gax-go/v2 v2.12.0

github.com/kubernetes-sigs/cri-tools => github.com/k3s-io/cri-tools v1.29.0-k3s1
Copy link
Member

@vitorsavian vitorsavian May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galal-hussein quick question, shouldn't cri-tools supposed to be v1.30.0-k3s1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cri-tools is only used for crictl binary, which is still compatible with 1.30

@galal-hussein galal-hussein merged commit 144f5ad into k3s-io:master May 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants