Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker vendor #1627

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Update docker vendor #1627

merged 1 commit into from
Apr 14, 2020

Conversation

loganhz
Copy link
Contributor

@loganhz loganhz commented Apr 9, 2020

Related issue #1554 (comment)

Users cannot use kubectl top pods in Docker mode due to docker vendor in k3s.

The docker vendor version we are using now will break cadvisor .

Tested in docker 17.03, 18.03, 18.04,18.06,18.09 and 19.03

The docker vendor tag is v18.06.3-ce

@loganhz loganhz changed the title Use the same docker vendor with upstream k8s Update docker vendor Apr 10, 2020
@sh0rez
Copy link

sh0rez commented Apr 12, 2020

Tested this out, can confirm it works. Thanks!

@erikwilson
Copy link
Contributor

Thanks @loganhz!

@erikwilson erikwilson merged commit 5c3d750 into k3s-io:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants