Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make etcd use node private ip #2448

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Make etcd use node private ip #2448

merged 1 commit into from
Oct 28, 2020

Conversation

MonzElmasry
Copy link
Contributor

@MonzElmasry MonzElmasry commented Oct 28, 2020 •
edited

Proposed Changes

Etcd now uses advertised ip, which is the node external ip if it was passed to the cli, this change makes etcd use node private ip by default

Types of Changes

Bugfix

Verfication

run k3s server with --cluster-init and --node-external-ip and make sure k3s is up and running

Issue

#2345

Make etcd use node private ip
e8436cc 
Signed-off-by: MonzElmasry <menna.elmasry@rancher.com>
@MonzElmasry MonzElmasry requested a review from a team as a code owner October 28, 2020 21:46
@MonzElmasry MonzElmasry merged commit 523ccaf into k3s-io:master Oct 28, 2020
brandond pushed a commit to brandond/k3s that referenced this pull request Oct 28, 2020
@MonzElmasry @brandond
Merge pull request k3s-io#2448 from MonzElmasry/new_b
79bf3dd 
Make etcd use node private ip
brandond pushed a commit that referenced this pull request Oct 28, 2020
@MonzElmasry @brandond
Merge pull request #2448 from MonzElmasry/new_b
f8a4547 
Make etcd use node private ip
@kladiv
Copy link

kladiv commented Nov 26, 2020 •
edited

+1
I guess etcd peer IP should be set:

  1. Equal to --advertise-address <PRIVATE_IP> if specified
  2. Equal to kube-apiserver-arg "advertise-address=<PRIVATE IP>" if specified
  3. Equal to --external-node-ip/--node-ip if all previous one not specified

If I am right this should support the scenario below (e.g. bare-metal):
eth0 - Public IP --> --node-ip
eth1 - Private IP --> --advertise-ip (to be used by kube-apiserver and etcd peer ip)

@dweomer dweomer mentioned this pull request Dec 10, 2020
Merged
@mway-niels mway-niels mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@dweomer dweomer dweomer approved these changes

@briandowns briandowns briandowns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MonzElmasry @kladiv @brandond @dweomer @briandowns