Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fuse-overlayfs snapshotter (mainly for rootless mode) #2595

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

AkihiroSuda
Copy link
Contributor

Proposed Changes

Add fuse-overlayfs snapshotter.

Ubuntu and Debian kernels support mounting real overlayfs inside userns, but the vanilla kernel still does not allow it.

OTOH fuse-overlayfs can be mounted inside userns with the vanilla kernel (>= 4.18).

Types of Changes

New Feature

Verification

  • k3s server --rootless --snapshotter fuse-overlayfs

Linked Issues

This snapshotter requires fuse-overlayfs to be installed.
The binary is being added to k3s-root in k3s-io/k3s-root#29

Further Comments

@brandond brandond requested a review from a team December 1, 2020 06:59
@brandond
Copy link
Contributor

brandond commented Dec 1, 2020

@AkihiroSuda k3s-io/k3s-root#29 has been merged and I'm tagging a new release with your addition - can you update your PR to include k3s-root bump to v0.7.1?

Ubuntu and Debian kernels support mounting real overlayfs inside userns,
but the vanilla kernel still does not allow it.

OTOH fuse-overlayfs can be mounted inside userns with the vanilla kernel (>= 4.18).

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Contributor Author

done

@brandond
Copy link
Contributor

brandond commented Dec 1, 2020

Thanks! I'll try to get another pair of eyes on this in the morning so that we can get it merged.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@brandond brandond merged commit 27e64c7 into k3s-io:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants