-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fuse-overlayfs snapshotter (mainly for rootless mode) #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
approved these changes
Nov 25, 2020
@AkihiroSuda k3s-io/k3s-root#29 has been merged and I'm tagging a new release with your addition - can you update your PR to include k3s-root bump to v0.7.1? |
Ubuntu and Debian kernels support mounting real overlayfs inside userns, but the vanilla kernel still does not allow it. OTOH fuse-overlayfs can be mounted inside userns with the vanilla kernel (>= 4.18). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
done |
AkihiroSuda
force-pushed
the
fuse-overlayfs
branch
from
December 1, 2020 07:15
c5fbd21
to
d010798
Compare
Thanks! I'll try to get another pair of eyes on this in the morning so that we can get it merged. |
AkihiroSuda
force-pushed
the
fuse-overlayfs
branch
from
December 1, 2020 07:52
120330b
to
c1e000d
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
fuse-overlayfs
branch
from
December 1, 2020 08:19
c1e000d
to
b096031
Compare
dweomer
approved these changes
Dec 1, 2020
briandowns
reviewed
Dec 1, 2020
briandowns
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add fuse-overlayfs snapshotter.
Ubuntu and Debian kernels support mounting real overlayfs inside userns, but the vanilla kernel still does not allow it.
OTOH fuse-overlayfs can be mounted inside userns with the vanilla kernel (>= 4.18).
Types of Changes
New Feature
Verification
k3s server --rootless --snapshotter fuse-overlayfs
Linked Issues
This snapshotter requires
fuse-overlayfs
to be installed.The binary is being added to k3s-root in k3s-io/k3s-root#29
Further Comments