Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show go version when executes with --version. #2621

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Show go version when executes with --version. #2621

merged 1 commit into from
Dec 4, 2020

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang commented Dec 4, 2020 •
edited

Proposed Changes

Show go version when executes with --version.

k3s version v1.19.4+k3s-95ea0e16 (95ea0e16)
go version go1.15.2

Types of Changes

Enhancement

Verification

k3s --version
k3s-agent --version
k3s-server --version

Linked Issues

rancher/rke2#558 (review)

Further Comments

@c3y1huang
Show go version when executes with --version.
95ea0e1 
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
briandowns
briandowns approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for dong this here as well.

@brandond brandond merged commit 3f0f2b3 into k3s-io:master Dec 4, 2020
@c3y1huang c3y1huang deleted the c3y1/cli-go-version branch December 6, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@briandowns briandowns briandowns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c3y1huang @brandond @briandowns