Drop broken SupportNoneCgroupDriver support #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov Report
@@ Coverage Diff @@
## master #4065 +/- ##
=======================================
Coverage 11.71% 11.72%
=======================================
Files 133 133
Lines 9013 9009 -4
=======================================
Hits 1056 1056
+ Misses 7731 7727 -4
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AkihiroSuda
reviewed
Sep 22, 2021
| argsMap["feature-gates=SupportNoneCgroupDriver"] = "true" | ||
| argsMap["cgroups-per-qos"] = "false" | ||
| argsMap["enforce-node-allocatable"] = "" | ||
| logrus.Fatal("delegated cgroup v2 controllers are required for rootless.") | ||
| } |
There was a problem hiding this comment.
Can we have a link to https://rootlesscontaine.rs/getting-started/common/cgroup2/ in the error message?
There was a problem hiding this comment.
We don't generally put URLs in our error messages. We can update the docs so that searching for the error points users to the correct location.
briandowns
approved these changes
Sep 23, 2021
dweomer
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Drop broken SupportNoneCgroupDriver support
Types of Changes
rootless
Verification
Run k3s rootless
Linked Issues
#3596
User-Facing Change
Further Comments