-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when using a "K10" prefixed token #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dereknola <derek.nola@suse.com>
brandond
requested changes
Oct 7, 2021
Co-authored-by: Brad Davidson <brad@oatmail.org>
Codecov Report
@@ Coverage Diff @@
## master #4180 +/- ##
==========================================
- Coverage 11.66% 11.46% -0.20%
==========================================
Files 134 134
Lines 9055 9242 +187
==========================================
+ Hits 1056 1060 +4
- Misses 7773 7956 +183
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brandond
approved these changes
Oct 7, 2021
briandowns
approved these changes
Oct 11, 2021
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 8, 2021
* Add new error message with a K10 prefixed secret token Signed-off-by: dereknola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dereknola derek.nola@suse.com
Proposed Changes
Improve the error message a user receives when accidentally providing a "K10" prefixed token on the first (or single node) K3s server.
Types of Changes
Enhancement
Verification
Linked Issues
#4169
User-Facing Change
Further Comments