refactor: Use plain channel send or receive #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue k3s-io#4369 should use a simple channel send/receive instead of select with a single case Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4370 +/- ##
=======================================
Coverage 11.56% 11.56%
=======================================
Files 135 135
Lines 9331 9330 -1
=======================================
Hits 1079 1079
+ Misses 8021 8020 -1
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dereknola
approved these changes
Nov 1, 2021
brandond
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
should use a simple channel send/receive instead of select with a single case
Types of Changes
code hygiene
Verification
see linked PR
Linked Issues
User-Facing Change
Further Comments