Match to last After keyword for parser #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
approved these changes
Nov 2, 2021
brandond
requested changes
Nov 2, 2021
brandond
requested changes
Nov 3, 2021
Signed-off-by: dereknola <derek.nola@suse.com> Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
k3s_etcd_config_fix
branch
from
2219c96
to
acc1c71
Compare
brandond
requested changes
Nov 4, 2021
brandond
approved these changes
Nov 4, 2021
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 12, 2021
* Made parser able to skip over subcommands * Edge case coverage, reworked regex with groups Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 12, 2021
* Made parser able to skip over subcommands * Edge case coverage, reworked regex with groups Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Nov 12, 2021
* Made parser able to skip over subcommands * Edge case coverage, reworked regex with groups Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dereknola derek.nola@suse.com
Proposed Changes
Currently the parser returns after finding the first valid keyword of After fields, now it returns the last. This enables matching on both command and subcommands for flag insertion.
Types of Changes
Bugfix
Verification
Unit test
Same S3 verification used in #4280 now works for all subcommands (save list delete prune)
Linked Issues
#4379
User-Facing Change
Further Comments