Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected skip check for dualstack on CI #4427

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

dereknola
Copy link
Contributor

Signed-off-by: dereknola derek.nola@suse.com

Proposed Changes

Fixed checks on dualstack test in CI. Test is currently flaky because depending on how fast/slow the test "skips" through the body, the k3s server may have already crashed from an incorrect startup, causing failures in later tests.

Types of Changes

Verification

export CI=true
go test -v ./test/integration/dualstack/... -run Integration properly skips both the test body and startup/teardown

Linked Issues

#4339

User-Facing Change


Further Comments

Signed-off-by: dereknola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner November 8, 2021 21:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #4427 (8c4bba8) into master (7bd6504) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4427   +/-   ##
=======================================
  Coverage   11.64%   11.64%           
=======================================
  Files         135      135           
  Lines        9343     9343           
=======================================
  Hits         1088     1088           
  Misses       8022     8022           
  Partials      233      233           
Flag Coverage Δ
inttests 0.74% <ø> (ø)
unittests 11.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd6504...8c4bba8. Read the comment docs.

@dweomer dweomer merged commit d85b246 into k3s-io:master Nov 8, 2021
@dereknola dereknola deleted the dualstack_ci_flaky branch November 16, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants