Bump wharfie to v0.5.1 #4575
Merged
Bump wharfie to v0.5.1 #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandond
force-pushed
the
bump_wharfie
branch
from
36ae300
to
8a6fad2
Compare
Codecov Report
@@ Coverage Diff @@
## master #4575 +/- ##
==========================================
+ Coverage 12.03% 12.05% +0.01%
==========================================
Files 135 135
Lines 9179 9165 -14
==========================================
Hits 1105 1105
+ Misses 7838 7824 -14
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brandond
force-pushed
the
bump_wharfie
branch
from
8a6fad2
to
253438e
Compare
dweomer
reviewed
Dec 7, 2021
| github.com/rancher/wrangler v0.8.8 | ||
| github.com/robfig/cron/v3 v3.0.1 | ||
| github.com/rootless-containers/rootlesskit v0.14.5 | ||
| github.com/sirupsen/logrus v1.8.1 | ||
| github.com/spf13/pflag v1.0.5 | ||
| github.com/stretchr/testify v1.7.0 | ||
| github.com/tchap/go-patricia v2.3.0+incompatible // indirect | ||
| github.com/urfave/cli v1.22.2 | ||
| github.com/urfave/cli v1.22.4 |
There was a problem hiding this comment.
Haven't we been sticking to urfave/cli v1.22.2 because of a regression with string-slice args?
There was a problem hiding this comment.
if so we never pinned it with a replace entry.
dweomer
approved these changes
Dec 7, 2021
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
bump_wharfie
branch
from
253438e
to
b1061bb
Compare
briandowns
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bump wharfie to v0.5.1
Updates Wharfie to latest and switches to using shared decompression code.
Types of Changes
Library version bump
Verification
Normal CI + QA
Linked Issues
User-Facing Change
Further Comments