[master] Add validation to certificate rotation #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
dereknola
approved these changes
Dec 8, 2021
briandowns
reviewed
Dec 8, 2021
pkg/cli/cert/cert.go
Outdated
| @@ -219,3 +223,23 @@ func backupCertificates(serverDataDir, agentDataDir string) (string, error) { | |||
| } | |||
| return tlsBackupDir, nil | |||
| } | |||
|
|
|||
| func validateCertConfig() error { | |||
| for _, service := range cmds.ServicesList { | |||
There was a problem hiding this comment.
Can you create a helper method and simplify this logic?
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
briandowns
approved these changes
Dec 8, 2021
brandond
approved these changes
Dec 8, 2021
| @@ -34,6 +34,20 @@ const ( | |||
| k3sServerService = "-server" | |||
| ) | |||
|
|
|||
| var services = []string{ | |||
There was a problem hiding this comment.
a more efficient way to do this would be to make this a map[string]struct{} or map[string]bool and then just see if the service name is in the map instead of having to walk the whole list each time, but this is fine.
|
CI is failing because of test validation flake, merging PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: galal-hussein hussein.galal.ahmed.11@gmail.com
Proposed Changes
Add validation to certificate rotation service
Types of Changes
bugfix
Verification
the subcommand should return error: