Add in docs/adr to ensure we capture decisions properly #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calls Signed-off-by: Chris Wayne <cwayne18@gmail.com>
briandowns
approved these changes
Dec 9, 2021
dweomer
approved these changes
Dec 9, 2021
brandond
requested changes
Dec 9, 2021
|
AFAIK not for the drone builds. The github actions are already skipped based off a change I made awhile ago, but IIRC there was no similar mechanism for drone that I could find @brandond |
brandond
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Wayne cwayne18@gmail.com
Proposed Changes
Add in first ADR, denoting our decision to use ADRs and to act as a template
Types of Changes
Docs changes
Verification
Verify that docs/adr dir exists
Linked Issues
User-Facing Change
Further Comments