Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the ability to compress etcd snapshots #4866

Merged
merged 5 commits into from Jan 14, 2022
Merged

Adds the ability to compress etcd snapshots #4866

merged 5 commits into from Jan 14, 2022

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Jan 4, 2022 •
edited by brandond

Proposed Changes

Adds the ability to compress etcd snapshots using Go's zip package for feature parity with RKE1.

Types of Changes

Verification

Scenario 1:

  1. Create a new cluster.
  2. Take a snapshot: ./k3s etcd-snapshot --snapshot-compress.
  3. Stop the cluster.
  4. Perform a restore.

Scenario 2:

  1. Create a new cluster.
  2. Take a snapshot: ./k3s etcd-snapshot --snapshot-compress.
  3. Stop the cluster.
  4. Remove the ${data-dir}.
  5. Perform a restore.

Linked Issues

User-Facing Change

Further Comments

@briandowns briandowns requested a review from a team January 4, 2022 20:18
@briandowns briandowns self-assigned this Jan 4, 2022
brandond
brandond requested changes Jan 4, 2022
View reviewed changes
pkg/etcd/etcd.go Outdated Show resolved Hide resolved
@Oats87 Oats87 self-requested a review January 5, 2022 05:15
@briandowns
unexport symbols not used outside of package
ca29b58 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns
add etcd snapshot compression
074dfdf 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns
update header filename and modified time
4d4d887 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns
deactivate unneeded linter check
18f0a14 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns
deactivate unneeded linter check
e952cb5 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns briandowns merged commit effcb15 into k3s-io:master Jan 14, 2022
briandowns added a commit to briandowns/k3s that referenced this pull request Jan 14, 2022
@briandowns
Adds the ability to compress etcd snapshots (k3s-io#4866)
b2cb199 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
briandowns added a commit to briandowns/k3s that referenced this pull request Jan 14, 2022
@briandowns
Adds the ability to compress etcd snapshots (k3s-io#4866)
d3a49f1 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
briandowns added a commit to briandowns/k3s that referenced this pull request Jan 14, 2022
@briandowns
Adds the ability to compress etcd snapshots (k3s-io#4866)
8e7aeff 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
briandowns added a commit that referenced this pull request Jan 18, 2022
@briandowns
Adds the ability to compress etcd snapshots (#4866) (#4960)
354477a 
Signed-off-by: Brian Downs <brian.downs@gmail.com>
briandowns added a commit that referenced this pull request Jan 18, 2022
@briandowns
[Release-1.21] Adds the ability to compress etcd snapshots (#4866) (#…
900e5ff 
…4959)
briandowns added a commit that referenced this pull request Jan 18, 2022
@briandowns
[Engine-1.21] Adds the ability to compress etcd snapshots (#4866) (#4958
8755fd4 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@galal-hussein galal-hussein galal-hussein approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87

Assignees

@briandowns briandowns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@briandowns @brandond @galal-hussein