Populate EtcdConfig in runtime from datastore when etcd is disabled #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with secrets-encrypt rotate not having any etcd endpoints available on nodes without a local etcd server. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
dereknola
approved these changes
Mar 8, 2022
briandowns
approved these changes
Mar 8, 2022
dereknola
pushed a commit
to dereknola/k3s
that referenced
this pull request
Mar 8, 2022
…3s-io#5222) Fixes issue with secrets-encrypt rotate not having any etcd endpoints available on nodes without a local etcd server. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
dereknola
pushed a commit
to dereknola/k3s
that referenced
this pull request
Mar 8, 2022
…3s-io#5222) Fixes issue with secrets-encrypt rotate not having any etcd endpoints available on nodes without a local etcd server. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
dereknola
pushed a commit
to dereknola/k3s
that referenced
this pull request
Mar 8, 2022
…3s-io#5222) Fixes issue with secrets-encrypt rotate not having any etcd endpoints available on nodes without a local etcd server. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This was referenced Mar 8, 2022
dereknola
added a commit
that referenced
this pull request
Mar 8, 2022
…d is disabled (#5229) * Populate EtcdConfig in runtime from datastore when etcd is disabled (#5222) Fixes issue with secrets-encrypt rotate not having any etcd endpoints available on nodes without a local etcd server. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> * Revert to old Kine naming Signed-off-by: Derek Nola <derek.nola@suse.com> Co-authored-by: Brad Davidson <brad.davidson@rancher.com>
dereknola
added a commit
that referenced
this pull request
Mar 8, 2022
… is disabled (#5230) * Populate EtcdConfig in runtime from datastore when etcd is disabled (#5222) Fixes issue with secrets-encrypt rotate not having any etcd endpoints available on nodes without a local etcd server. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> * Revert naming to old Kine Signed-off-by: Derek Nola <derek.nola@suse.com> Co-authored-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes issue with secrets-encrypt rotate not having any etcd endpoints available on nodes without a local etcd server.
Types of Changes
bugfix
Verification
See linked issue
Linked Issues
secrets-encryptsubcommand with CP/Etcd-Only configuartion. #5225User-Facing Change
Further Comments
Thanks @dereknola for the pairing!