[release-1.22] Defragment etcd datastore before clearing alarms; don't delete temp etcd db while reconciling #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
approved these changes
Mar 26, 2022
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
etcd_defragment_release-1.22
branch
from
046cb6d
to
e1fcb0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Defragment etcd datastore before clearing alarms.
This also fixes an issue wherein we were deleting the temporary etcd directory while the reconcile etcd was still running. This doesn't seem to be currently causing any problems, as etcd seems to be able to open the files and read them into memory before they are unlinked, but it could possibly cause problems reconciling larger datastores, and it was definitely breaking the defragmentation and clearing of alarms on the reconciliation datastore.
Types of Changes
bugfix
Verification
Not sure how to reproduce this one, since it requires a datastore that is not just over quota but also defragmented. It would probably require setting up a long-running cluster with lots of datastore churn.
Linked Issues
User-Facing Change
Further Comments