[master] Wrap containerd.New #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luthermonson
changed the title
luthermonson
force-pushed
the
fix-containerd-npipe
branch
from
93f3615
to
7cf1280
Compare
rosskirkpat
approved these changes
Mar 29, 2022
luthermonson
force-pushed
the
fix-containerd-npipe
branch
from
7cf1280
to
9e41526
Compare
…er npipe connector Signed-off-by: Luther Monson <luther.monson@gmail.com>
luthermonson
force-pushed
the
fix-containerd-npipe
branch
from
9e41526
to
13191da
Compare
Codecov Report
@@ Coverage Diff @@
## master #5361 +/- ##
=========================================
- Coverage 9.69% 9.68% -0.01%
=========================================
Files 133 133
Lines 9377 9381 +4
=========================================
Hits 909 909
- Misses 8275 8279 +4
Partials 193 193
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brandond
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: While setting up containerd we make a client and the name of the npipe for windows is
npipe://./pipe/containerd-containerdbut at some point between windows server patches and the winio dialer we got to a place where it's expecting\\.\pipe\containerd-containerdand the npipe:// needed to be dropped. This was fixed CriConnection as the address was wrapped withutils.GetAddressAndDialerbut the second call to containerd.New for a client didn't have this.Fix: wrap the containerd.New call with a func that parses the address properly and pass that down
rancher/rke2#2161
rancher/windows#72